Skip to content

Conversation

@AndersonTsaiTW
Copy link
Contributor

@AndersonTsaiTW AndersonTsaiTW commented Oct 12, 2025

Pull Request Guidelines

  • I built a new branch and added the new feature after all the changes you made to the repo. I guess it will be easier for you to review.

Before Submitting

  • Code builds without errors or warnings
  • Changes have been tested manually
  • Commit messages are clear and descriptive
  • No unnecessary files are included (build artifacts, IDE files, etc.)

PR Description Should Include

  • What: Add Windows network monitoring and related moods
  • Why: This feature is listed in the “awaiting contributions” section, and monitoring network speed is also a fundamental part of system resource tracking.
  • How: Uses GetIfTable, 3s sampling, 64-bit accumulation + wrap-around handling.
  • Testing: use g++ -Iinclude src/main.cpp -o SysMood.exe -liphlpapiand run the .exe. file

!! Important: You must compile with g++ -Iinclude src/main.cpp -o SysMood.exe -liphlpapi because the network module depends on the iphlpapi library. (CMake already links Iphlpapi automatically on Windows.)

Closes #7

image image

@RayBreeze RayBreeze self-requested a review October 13, 2025 05:01
- Wrap Windows-specific code with #ifdef _WIN32
- Provide stub implementation for non-Windows platforms
- Prevent CI compilation errors on Linux builds
@AndersonTsaiTW
Copy link
Contributor Author

Added platform guards to preserve space for Linux/macOS implementation.

If you’d like, you can go ahead and merge this PR first — it will only take effect on the Windows version for now. I can open a separate issue later to implement the Ubuntu version.

It can still run properly on WIN
image

Copy link
Owner

@RayBreeze RayBreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AndersonTsaiTW, I reviewed the code and found out almost fine, also it now passed the CI Pipelines. So I am merging it with main branch. Thank you very much for your Contribution. It would really make SysMood better. Looking forward for more contributions from you. Thank you very much.

Regards,
Samman

@RayBreeze RayBreeze merged commit 206c5a7 into RayBreeze:main Oct 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add network stats to display bytes sent/received

2 participants