Skip to content

Conversation

@RayBreeze
Copy link
Owner

@RayBreeze RayBreeze commented Oct 7, 2025

This pull request simplifies the CI workflow configuration by focusing exclusively on Windows builds and streamlining the build steps. The main changes are the removal of Ubuntu support and related setup steps, as well as making the build and configuration commands more concise.

Platform support changes:

  • Dropped Ubuntu from the CI matrix, so the workflow now only runs on Windows (windows-latest).

Build and setup simplification:

  • Removed the steps for setting up CMake on Ubuntu and the MSVC development environment on Windows, consolidating the configuration process.
  • Simplified the build and configuration commands to use direct CMake options, reducing complexity and improving clarity. This ensures the CI pipeline always uses the most up-to-date version of CMake.

Removed unnecessary 'cd build' command before building.
Updated CI workflow to combine configure and build steps.
Removed Ubuntu from the CI workflow matrix and the related dependency installation step. As Linux build is not currently available right now.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request simplifies the CI workflow by removing Ubuntu builds and streamlining the CMake configuration process. The changes focus on Windows-only builds with a more concise CMake setup.

  • Removed Ubuntu from the build matrix, making it Windows-only
  • Eliminated platform-specific setup steps for both Ubuntu (CMake) and Windows (MSVC)
  • Simplified CMake configure and build commands to use modern single-line syntax

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@RayBreeze
Copy link
Owner Author

Check please now @copilot

@RayBreeze RayBreeze requested a review from Copilot October 7, 2025 03:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@RayBreeze RayBreeze merged commit 58df360 into main Oct 7, 2025
1 check passed
@RayBreeze RayBreeze deleted the CI-Actions-patch branch October 7, 2025 03:42
@RayBreeze RayBreeze added the enhancement New feature or request label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants