Support building for C++98 on GLIBC using a vsnprintf wrapper. #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Un1q32
changed the title
BrentDaMage
requested changes
Jan 4, 2026
Collaborator
BrentDaMage
left a comment
BrentDaMage
left a comment
There was a problem hiding this comment.
All of the vsnprintf stuff should be moved to compat/LegacyCPP_Compat.hpp
Un1q32
force-pushed
the
master
branch
2 times, most recently
from
7507206 to
a464661
Compare
Un1q32
force-pushed
the
master
branch
3 times, most recently
from
7bea725 to
891a98a
Compare
BrentDaMage
requested changes
Jan 4, 2026
Un1q32
force-pushed
the
master
branch
2 times, most recently
from
94a5803 to
fdc72f6
Compare
BrentDaMage
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(v)snprintf requires C99, GLIBC refuses to declare it for lower standards. I don't think there's many devices that would be capable of running ReMCPE that don't have a C99 compliant libc, and we already kinda depend on C99 through things like C99 only printf format arguments. My solution is just to declare a wrapper function in a C file that gets compiled with
-std=c99.MinGW must still be built for C++11 since their C++ headers don't support anything lower and intentionally error.
These projects should really be setup to detect all source files in directories automatically so it's not such a pain to add a new file.