More compiler warns #253
Merged
More compiler warns #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Un1q32
force-pushed
the
extra-compiler-warns
branch
from
d7b95b3 to
6af9d84
Compare
Un1q32
force-pushed
the
extra-compiler-warns
branch
3 times, most recently
from
bba38da to
032525c
Compare
Un1q32
force-pushed
the
extra-compiler-warns
branch
from
032525c to
4c9c190
Compare
Un1q32
force-pushed
the
extra-compiler-warns
branch
3 times, most recently
from
55bc81a to
553d174
Compare
Un1q32
force-pushed
the
extra-compiler-warns
branch
from
553d174 to
4c9c190
Compare
Un1q32
force-pushed
the
extra-compiler-warns
branch
from
9a2c640 to
174fea2
Compare
BrentDaMage
requested changes
Jan 7, 2026
Contributor
Author
|
note that after this pr log macro arguments are evaluated even in release builds, so be careful logging the results of expensive functions. |
Collaborator
Can you make sure this won't have any adverse effects to the current codebase? |
Contributor
Author
|
I ended up finding a way to not evaluate arguments on release builds, instead of |
Collaborator
Great |
Un1q32
force-pushed
the
extra-compiler-warns
branch
from
c13efb9 to
19706ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wextraenables some warns we don't want, so this just enables some parts we do want.Also fixes 1 sign compare warn that was missed, and fixes a bug where a variable wasn't properly initialized.