Skip to content

Conversation

@pmoleri
Copy link

@pmoleri pmoleri commented Nov 11, 2025

Description:

The documentation mentions and the code allow for undefined parameter (and null), but the exported types didn't allow it.

Example mentioned in the existing JSDoc:

// We only want the events where it changed hands
const changedHands$ = accountUpdates$.pipe(
  distinctUntilChanged(undefined, update => update.updatedBy)
);

And the code includes a comment where it mentions null is also allowed:

// We've been allowing `null` do be passed as the `compare`, so we can't do
// a default value for the parameter, because that will only work
// for `undefined`.
comparator = comparator ?? defaultCompare;

Both the documentation and the code allow for undefined parameter (and null), but in the exported types didn't allow it.
@nx-cloud
Copy link

nx-cloud bot commented Nov 11, 2025

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit e855af4

Command Status Duration Result
nx compile rxjs ❌ Failed 27s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-11 14:07:03 UTC

@pmoleri pmoleri marked this pull request as draft November 11, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant