fix: ensure weapon index is within valid 16-bit range #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a bitwise AND operation (`index = index & 0xFFFF`) at the beginning of the `get_weapon_name_by_index` function to ensure that the input index is always within the valid 16-bit range. This prevents issues caused by negative or out-of-range values that could result from unsigned-to-signed integer conversions or memory reading anomalies.
This change helps improve reliability when integrating with game memory structures where weapon indices may contain additional flags or unintended bits.
Also noticed a key duplication for index 43 ("Galil" and "Flashbang"). Only the last entry will be used due to dictionary behavior. Galil New Index -> 13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a bitwise AND operation (
index = index & 0xFFFF) at the beginning of theget_weapon_name_by_indexfunction to ensure that the input index is always within the valid 16-bit range. This prevents issues caused by negative or out-of-range values that could result from unsigned-to-signed integer conversions or memory reading anomalies.This change helps improve reliability when integrating with game memory structures where weapon indices may contain additional flags or unintended bits.
Also noticed a key duplication for index 43 ("Galil" and "Flashbang"). Only the last entry will be used due to dictionary behavior.