Align HTTP signature validation with Hub spec#100
Merged
Conversation
Point 3 (SSRF guard): - Block reserved, multicast, and unspecified IP ranges in _is_blocked_ip (in addition to private/loopback/link-local). - Require https for actor fetches by default; plain http is only allowed when AP_ALLOW_INSECURE_HTTP is set (enabled in development). - Make follow_redirects=False explicit on the httpx client. Point 5 (accepted algorithms): - Accept hs2019 alongside rsa-sha256; with an RSA key both denote the same RSA-PKCS1v15/SHA-256 signature (hs2019 is Mastodon's advertised default), so they verify identically. Adds tests covering hs2019 acceptance, unknown-algorithm rejection, the new blocked IP ranges, and https-only enforcement. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QrWgMrRyfByCYafRwaYW6a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point 3 (SSRF guard):
(in addition to private/loopback/link-local).
when AP_ALLOW_INSECURE_HTTP is set (enabled in development).
Point 5 (accepted algorithms):
RSA-PKCS1v15/SHA-256 signature (hs2019 is Mastodon's advertised default),
so they verify identically.
Adds tests covering hs2019 acceptance, unknown-algorithm rejection, the new
blocked IP ranges, and https-only enforcement.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01QrWgMrRyfByCYafRwaYW6a