fix(navigation-primary): item menu padding #2360
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +203 B (+0.09%) Total Size: 234 kB
ℹ️ View Unchanged
|
|
Some thoughts on how we might patch this without adding any new CSS:
|
In the future, yes/maybe, given @MagRat04 work on Right now, it's just slotted standard HTML content from drupal
I'm hesitant on this. That would mean for all dropdowns, whereas this change is really for just 1. The default is you have padding. The account dropdown right now is the exception. |
|
The padding is also ONLY removed in the "unauthed" state. Authed: Unauthed: The original slot's intent was to maintain the padding across all the dropdowns, which was also because those dropdowns hadn't been designed when the component was created. I'm wondering, given @MagRat04's work, if we can use a check to see if the For RHDC purposes, because they likely won't use Update: "RHDC purposes, because they likely won't use". They do use the account dropdown, so this would be a viable option. |
|
I'd prefer if we get some clarity on the allowed content from our stakeholders before proceeding with this |
|
@zeroedin @bennypowers where are we at on this fix? Will it make it into Diglett? |
|
@markcaron no we can't move on this until PMs come in with a clearly delineated business case e.g. "when there's a login avatar in the menu, remove the padding" or something like that |
What I did
rh-navigation-primary-item-menucontainer.--rh-navigation-primary-item-menu-padding-block-endrh-navigation-itemTesting Instructions
rh-navigation-primary-item { --rh-navigation-primary-item-menu-padding-block-end: 0; }Notes to Reviewers
I think this is likely a
minorchange due to the addition of the new functionality, but because we are releasing nav in a controlled way right now and know our consumers, maybe we can squeeze this as a patch-level concern. Thoughts? Will add changeset when we resolve this question.I also made the choice to document the new CSS prop on
rh-navigation-itemasrh-navigation-item-menuis used in the shadowroot ofrh-navigation-itemand would not be available to use as a selector to modify the value.Here is an example of intended use: