-
Notifications
You must be signed in to change notification settings - Fork 33
chore: add @html-eslint #2385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: add @html-eslint #2385
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
looks pretty good. I'm going to add some html stylistic rule config, which should help with @MagRat04's questions about autoformatting |
|
@yeonjuan thanks for dropping by. this looks pretty good, and solves some problems for us. I'll probably wait to merge until the number of active PRs calms down a bit. I'd like to see an indent option that matches the html lsp formatting config, specifically for us we like
all good: <a id="hello" class="world" href="#">Content</a>
<a id="hello"
class="world"
href="#">Content</a>or with 4 spaces config: <a id="hello"
class="world"
href="#">Content</a> |
html`
<div id="1"
class="1"
wrongIndent="2"
onclick="click"
>
`;
html`<div id="1" class="1" wrongIndent="2" onclick="click">`;Thank you for the response! |
What I did
I'm a maintainer of the html-eslint plugin, which brings HTML linting support to ESLint.
While exploring this project, I tried applying html-eslint and found that it works well here. This PR adds HTML linting and includes a few fixes based on the results .
If this seems useful, I’d be happy to discuss further or help tune the lint rules for your setup. Would you be interested?
Testing Instructions
npm run lintNotes to Reviewers