-
Notifications
You must be signed in to change notification settings - Fork 33
docs: lazy load images #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: lazy load images #2470
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 230 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes overall. Perhaps these changes will make uxdot the fastest site at Red Hat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should automate this with https://jampack.divriots.com/ instead of editing source files
Hmm, interesting, didn't know this existed. I'll take a look at implementing this instead. Update: Jampack takes....foreveeeeerrrrrr to run. Maybe overkill. Maybe gets run in CI and not locally, definitely not on incrementals anyway? Not sure I'm thrilled with |
|
I'm not married to that tool specifically. The main point is to not make this an opt-in / developer discipline thing. It's better to automate than to nag We could write an 11ty transform, find another processor, etc. Make a golang project of it 😉 I've had experience with jampack. I agree performance kinda sucks though |
What I did
loading="lazy"to all images indoc/*Closed #1958
Testing Instructions
Notes to Reviewers
AI assisted with this PR. Please review each line changed fairly closely. I gave it a thorough once-over myself, but with over 300 edits, I could have missed something as well.