-
Notifications
You must be signed in to change notification settings - Fork 33
fix(jump-links): non-contiguous content #2471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@tejas161 test this by pulling latest commit and running |
|
Thanks @bennypowers for pushing the fix ! Here is what I observed:
Would it be possible to always target the section at the top of the viewport, similar to the behavior shown here: https://ux.redhat.com/elements/jump-links/demo/nested/? Let me know what you think! Attaching video of observed behaviour:- |
|
This isn't quite ready yet. @tejas161 ' most recent feedback on https://deploy-preview-2471--red-hat-design-system.netlify.app/elements/jump-links/demo/non-contiguous-regions/#chapter-5
Screen.Recording.2025-08-06.at.17.28.10.mov@adamjohnson can you give this a whack in patternfly/patternfly-elements#2920? |
What I did
Testing Instructions
Notes to Reviewers
See #2474 for more info.