GetGroupUsers adding query param admin_only #3273
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwenneg
reviewed
Feb 11, 2025
.../main/java/com/redhat/cloud/notifications/recipients/resolver/rbac/RbacServiceToService.java
Show resolved
Hide resolved
gwenneg
reviewed
Feb 11, 2025
| @@ -312,6 +312,7 @@ public List<User> getGroupUsers(String orgId, boolean adminOnly, UUID groupId) { | |||
| } else { | |||
| users = getWithPagination(page -> { | |||
| Timer.Sample getGroupUsersPageTimer = Timer.start(meterRegistry); | |||
| // or do i have to add it here | |||
There was a problem hiding this comment.
Yes, you need to pass the adminOnly argument from line 289 to the rbacServiceToService.getGroupUsers method. Then lines 324 to 328 will no longer be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rbac added a new query parameter for getgroupusers called admin_only. Now we don't have to use our own filtering for adminonly.