feat(MTV-664): add insecureSkipVerify plan-readiness test - #628
Conversation
Add a 4-step plan-readiness test verifying a source provider with insecureSkipVerify=true reaches Ready status. Follows the existing ca_crt fixture pattern with unique fixture names (insecure_source_provider, insecure_source_provider_inventory).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughAdds cold migration coverage for source providers with ChangesInsecure cold migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Test
participant SourceProvider
participant ForkliftInventory
participant MigrationResources
Test->>SourceProvider: Create provider with insecureSkipVerify=true
Test->>SourceProvider: Validate provider Secret
Test->>ForkliftInventory: Create inventory
Test->>MigrationResources: Create StorageMap and NetworkMap
Test->>MigrationResources: Create MTV Plan
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
PR Summary by QodoAdd insecureSkipVerify plan-readiness cold migration test (MTV-664)
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo
1.
|
RHV providers don't support skip_clone (templates must be cloned into VMs to appear in Forklift inventory). Split into two test classes: - TestInsecureSkipVerifyColdMigration: vsphere/openstack/esxi with skip_clone - TestInsecureSkipVerifyRhvColdMigration: RHV-only without skip_clone Also revert skip_clone from ca_crt config (back to pre-PR behavior).
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/cold/test_insecure_skip_verify_migration.py`:
- Around line 195-200: Update the preparation fixture chain used by
test_verify_insecure_skip_verify and the related tests so plan creation and
Multus discovery use insecure_source_provider and
insecure_source_provider_inventory instead of the normal source-provider
fixtures. Preserve the required class-level indirect fixture chain, changing
only its source-provider branch; add insecure fixture equivalents or
parameterize the existing fixtures accordingly.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 1efff02d-abdc-4749-bb80-27014a8500e5
📒 Files selected for processing (2)
tests/cold/test_insecure_skip_verify_migration.pytests/tests_config/config.py
|
Code review by qodo was updated up to the latest commit a792fd2 |
|
/verified |
Add a 4-step plan-readiness test verifying a source provider with insecureSkipVerify=true reaches Ready status. Follows the existing ca_crt fixture pattern with unique fixture names
(insecure_source_provider, insecure_source_provider_inventory).
Summary by CodeRabbit