Skip to content

Enable async modelset + refactor of model creation #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alonre24
Copy link
Collaborator

@alonre24 alonre24 commented Apr 9, 2021

  • This PR touches many source files. It is not final yet (looks like there are some problems with RDB loading + valgrind check is required)
  • There are 2 main changed (both concern model set):
  1. MODELSET command is processed in a background thread. The design is generic, so that this background thread will be able to get more types of "Jobs" in the future.
  2. Refactor in creation of RAI_Model - instead of creating it for every backend separably, it is now created beforehand with all the common fields that are agnostic to the BE, and then every backend enriches the object fields (model/session) as needed.

TODO

  • Replace RedisModule_Replicateverbatim with RedisModule_Replicate (in reply callback) - replicas currently not working for this command.
  • Update the changes in RDB load v0
  • Enable running the commad from within LUA/MULTI (without blocking).

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants