Skip to content

Commit

Permalink
Disable dumping of headers on trace
Browse files Browse the repository at this point in the history
Some headers (e.g.: Authorization) contains sensitive information
which should not be logged.
  • Loading branch information
slavak committed Dec 22, 2024
1 parent cbda1d1 commit 05dc11e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion source/common/http/filter_manager.h
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,8 @@ class FilterManager : public ScopeTrackedObject,
const char* spaces = spacesForLevel(indent_level);
os << spaces << "FilterManager " << this << DUMP_MEMBER(state_.has_1xx_headers_) << "\n";

DUMP_DETAILS(filter_manager_callbacks_.requestHeaders());
// Disabled to avoid dumping sensitive information (such as AUTHORIZATION header)
// DUMP_DETAILS(filter_manager_callbacks_.requestHeaders());
DUMP_DETAILS(filter_manager_callbacks_.requestTrailers());
DUMP_DETAILS(filter_manager_callbacks_.responseHeaders());
DUMP_DETAILS(filter_manager_callbacks_.responseTrailers());
Expand Down

0 comments on commit 05dc11e

Please sign in to comment.