fix de-duplicate issue in ZUNIONTOP/ZUNIONREVTOP #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvirsky @itamarhaber please have a review |
src/rxzsets.c
Outdated
|
|
||
| // de-duplicate | ||
| int ret = 0; | ||
| kh_put(32, h, RedisModule_StringPtrLen(entry->element, NULL), &ret); |
There was a problem hiding this comment.
this might be dangerous re NULL termination.
from client requests strigns are null terminated implicitly, but from RedisModule_Call responses they usually aren't.
You can strndup maybe and create a null terminated string if you can free it later.
|
@dvirsky Instead of copying string out, I write a hash function on RedisModuleString and put RedisModuleString into the hash set. |
|
@dvirsky @itamarhaber please have a review |
|
@itamarhaber I'm jet lagged and tired, so... :) |
|
ping @itamarhaber @dvirsky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix de-duplicate issue in ZUNIONTOP/ZUNIONREVTOP #8 #8