LAPACKE const correctness fixes #1162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved some spurious transpositions of output matrices that are in fact pure input parameters.
langou
approved these changes
Oct 23, 2025
|
What do you mean by "correctly specified as const in the LAPACK C interfaces"? What are the "LAPACK C interfaces" if not LAPACKE interfaces? |
|
With LAPACK C interfaces I meant the C declarations in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some matrix arguments in the LAPACKE interfaces were not specified as const, even though they are clearly marked as pure inputs on the Fortran side and are correctly specified as const in the LAPACK C interfaces.
I changed all the pure inputs to be const. That revealed some spurious transpositions of "output" matrices (row-major cases) that are, in fact, only inputs. I removed those as well.
Checklist