Add non-trivial terminating case to xLARFT #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When originally creating the new recursive xlarft behavior, the case of NX=1 was sufficient for performance, however after further investigation into the x{or,un}g subroutines, we found that some hardware benefited from a larger NX value, and as a result, wanted to add this behavior before finishing the other development.
This was accomplished by moving the old level 2 version of larft from the variants into the main SRC folder and renaming it to include level 2 in the name as well as adding a choice of NX based on brief testing on my Zen 4 laptop.
Checklist