Fix for missing a grid cell at longitudes close to min_lon#1
Open
billetd wants to merge 5 commits intoRemingtonRohel:mainfrom
Open
Fix for missing a grid cell at longitudes close to min_lon#1billetd wants to merge 5 commits intoRemingtonRohel:mainfrom
billetd wants to merge 5 commits intoRemingtonRohel:mainfrom
Conversation
Author
|
Just added another commit because I realized the check also wasn't done for values close to the maximum longitude. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where longitudes that fell within a grid cell with a lower bound of
min_lonwere being excluded by awhere()call. This fix ensures that grid cell is actually included.