Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-4950 PowerCamera is now a Paper only plugin to fix that you can … #13

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Wolf2323
Copy link
Member

…spectate entities while a camera is active


  • The main commit(s) reference the Fibery ticket via a TASK-NNNN prefix in the commit message subject
  • Include a human-readable description of what the pull request is trying to accomplish
  • The CI build passes

  • New automated tests have been added
  • The changes are already covered by automated tests and have been adapted
  • These manual test cases cover this change:
  • Steps for the reviewer(s) on how they can manually QA the changes:
  • This is a minor internal change; basic CI/CD coverage is enough
  • This is an incomplete feature hidden behind feature flag:
  • This is proof-of-concept / experimental code not for production / marked @Deprecated
  • No (significant) changes to production code

  • Classes and public methods have documentation (that doesn't just repeat the technical subject in English)
  • Logging is implemented to monitor feature usage and troubleshoot problems in production
  • These ReWiki pages are affected by this change and will be adapted:

  • The change is unrelated to Minecraft
  • Works in Java edition
  • Works in Bedrock edition

@Wolf2323 Wolf2323 requested a review from Phoenix616 January 29, 2025 13:09
@Wolf2323 Wolf2323 force-pushed the TASK-4950/spectating branch from 6d71e33 to 34efb0d Compare January 29, 2025 13:56
@Wolf2323 Wolf2323 requested a review from Phoenix616 January 29, 2025 13:56
Copy link

@Phoenix616 Phoenix616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…spectate entities while a camera is active
@Wolf2323 Wolf2323 force-pushed the TASK-4950/spectating branch from 34efb0d to e5f4321 Compare January 30, 2025 09:09
@Wolf2323 Wolf2323 enabled auto-merge January 30, 2025 09:09
@Wolf2323 Wolf2323 merged commit a3be4f7 into main Jan 30, 2025
2 checks passed
@Wolf2323 Wolf2323 deleted the TASK-4950/spectating branch January 30, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants