maintenance(@videndum/release-mastermind): refactor contextHandler to static call within context files #198
Assignees
Labels
Context - Release Mastermind
Related to @resnovas/release-mastermind
DevOps - Developing
DevOPS are Developing
Status - In Progress
Development is underway for this issue
Type - Refactor
A code change that neither fixes a bug nor adds a feature
Milestone
Comments
VidendumStudios
added
Type - Refactor
TGTGamer
pushed a commit
that referenced
this issue
Aug 5, 2021
…videndum/release-mastermind): refactor the contextHandler.ts into ./src/contexts/ folder as static calls within classes Closes: #198
8 tasks
8 tasks
TGTGamer
added a commit
that referenced
this issue
Sep 11, 2021
…ma, staleness, schedules and more #AM-1 (#203) * refactor: overhall gulp files to make it easier to understand what is happening BREAKING CHANGE: Breaks previous gulp setup * revert(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): revert bump of @actions/github actions/github changes the way things are defined, and therefore needs to have a dedicated branch and pull to change this * chore: changes TSConfig to be more strict * refactor(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): rework type declarations Moved all type declarations into one file due to changed build method * chore(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): update utilities Moves some things out of old file into utilities to improve code, and adds new functionality to utilities * feat(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): adds Schedule and refactor all files accordingly Closes: #14 Adds the schedule context, refactors all files and utilises the new shouldRun() function. All Types changed which could lead to breaking changes on older versions of the actions TEST PLAN: Test in pull request BREAKING CHANGE: Possibly breaks configs. Verify your config * docs(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): updates documentation * chore(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): update config Signed-off-by: Jonathan Stevens <[email protected]> * refactor(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): misc Changes - Yarn.lock & action workflow * chore(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): release Build * refactor(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): refactor the contextHandler.ts into ./src/contexts/ folder as static calls within classes Closes: #198 * chore: Bump Version & Changelog Signed-off-by: Jonathan Stevens <[email protected]> * chore: Bump Version & Changelog Signed-off-by: Jonathan Stevens <[email protected]> * style: prettier styling changes * chore: Bump Version & Changelog Signed-off-by: Jonathan Stevens <[email protected]> * style: prettier changes * style: add period to end of sentence * feat(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): schema for JSON - allows for simpler configuration creation * chore: Bump Version & Changelog Signed-off-by: Jonathan Stevens <[email protected]> * Expected { after 'if' condition. Co-authored-by: Videndum Studios Github Actions <[email protected]> * Expected { after 'if' condition. Co-authored-by: Videndum Studios Github Actions <[email protected]> * chore: update workflow to have separate runs * chore: changes to the build process * refactor(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): refactor the entire project to enable new docs I have spent about an entire working day refactoring the entire project, to support typeDocs and much more. I've also added a lot of documentation and setup a schema for the JSON files * docs: documentation build * refactor(@videndum/label-mastermind): moves stale label assignment into the assign label process * refactor: upgrade @action/github to 5.0.0 Signed-off-by: Jonathan Stevens <[email protected]> * refactor: fix types which broke during upgrade Signed-off-by: Jonathan Stevens <[email protected]> * chore(@videndum/release-mastermind): drop support for submodules Drops support for all submodules which are extracted from main project. All functionality is now renamed "smartcloud" BREAKING CHANGE: Drops support for submodules * chore: Bump Version & Changelog Signed-off-by: Jonathan Stevens <[email protected]> * chore: delete accidently included junk Signed-off-by: Jonathan Stevens <[email protected]> Co-authored-by: Videndum Studios Github Actions <[email protected]>
TGTGamer
added a commit
that referenced
this issue
Sep 14, 2021
* refactor: overhall gulp files to make it easier to understand what is happening BREAKING CHANGE: Breaks previous gulp setup * revert(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): revert bump of @actions/github actions/github changes the way things are defined, and therefore needs to have a dedicated branch and pull to change this * chore: changes TSConfig to be more strict * refactor(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): rework type declarations Moved all type declarations into one file due to changed build method * chore(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): update utilities Moves some things out of old file into utilities to improve code, and adds new functionality to utilities * feat(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): adds Schedule and refactor all files accordingly Closes: #14 Adds the schedule context, refactors all files and utilises the new shouldRun() function. All Types changed which could lead to breaking changes on older versions of the actions TEST PLAN: Test in pull request BREAKING CHANGE: Possibly breaks configs. Verify your config * docs(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): updates documentation * chore(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): update config Signed-off-by: Jonathan Stevens <[email protected]> * refactor(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): misc Changes - Yarn.lock & action workflow * chore(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): release Build * refactor(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): refactor the contextHandler.ts into ./src/contexts/ folder as static calls within classes Closes: #198 * chore: Bump Version & Changelog Signed-off-by: Jonathan Stevens <[email protected]> * chore: Bump Version & Changelog Signed-off-by: Jonathan Stevens <[email protected]> * style: prettier styling changes * chore: Bump Version & Changelog Signed-off-by: Jonathan Stevens <[email protected]> * style: prettier changes * style: add period to end of sentence * feat(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): schema for JSON - allows for simpler configuration creation * chore: Bump Version & Changelog Signed-off-by: Jonathan Stevens <[email protected]> * Expected { after 'if' condition. Co-authored-by: Videndum Studios Github Actions <[email protected]> * Expected { after 'if' condition. Co-authored-by: Videndum Studios Github Actions <[email protected]> * chore: update workflow to have separate runs * chore: changes to the build process * refactor(@videndum/convention-mastermind,@videndum/label-mastermind,@videndum/release-mastermind): refactor the entire project to enable new docs I have spent about an entire working day refactoring the entire project, to support typeDocs and much more. I've also added a lot of documentation and setup a schema for the JSON files * docs: documentation build * refactor(@videndum/label-mastermind): moves stale label assignment into the assign label process * refactor: upgrade @action/github to 5.0.0 Signed-off-by: Jonathan Stevens <[email protected]> * refactor: fix types which broke during upgrade Signed-off-by: Jonathan Stevens <[email protected]> * chore(@videndum/release-mastermind): drop support for submodules Drops support for all submodules which are extracted from main project. All functionality is now renamed "smartcloud" BREAKING CHANGE: Drops support for submodules * chore: Bump Version & Changelog Signed-off-by: Jonathan Stevens <[email protected]> * chore: delete accidently included junk Signed-off-by: Jonathan Stevens <[email protected]> * chore: github workflow changes * style: minor Changes Co-authored-by: Videndum Studios Github Actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Maintenance Required
Type: Refactoring
Assignee: @TGTGamer
Risk: Low
Refactor the contextHandler.ts into ./src/contexts/ folder as static calls within classes
https://github.com/Videndum/Smartcloud/blob/5fbd201d7edfc6f32b34105a15729384bfcae134/package.json#L12-L16
Improvements
Reduction in files that need to be maintained - easier to follow code
Expected risks
Potential to break the context handling
Involved components
All components
The text was updated successfully, but these errors were encountered: