Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@videndum/release-mastermind): documentation overhaul, json schema, staleness, schedules and more #AM-1 #203

Merged
merged 34 commits into from
Sep 11, 2021

Conversation

TGTGamer
Copy link
Member

@TGTGamer TGTGamer commented Aug 5, 2021

Overhaul August 21

This pull request initially started as the implementation of Staleness, and schedules, and quickly grew to become an entire overhaul of the entire system.

References

Related issue(s): #198 #14 #AM-1

Author's checklist

Reviewing checklist

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Optional: Technical writer review. If not requested for this PR, must be scheduled post-merge.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.

BREAKING CHANGE: Changes configuration method. Please verify your config before updating.

Jonathan Stevens added 12 commits August 5, 2021 20:36
… happening

BREAKING CHANGE:
Breaks previous gulp setup
…dendum/release-mastermind): revert bump of @actions/github

actions/github changes the way things are defined, and therefore needs to have a dedicated branch
and pull to change this
…videndum/release-mastermind): rework type declarations

Moved all type declarations into one file due to changed build method
…endum/release-mastermind): update utilities

Moves some things out of old file into utilities to improve code, and adds new functionality to
utilities
…ndum/release-mastermind): adds Schedule and refactor all files accordingly

Closes: #14

Adds the schedule context, refactors all files and utilises the new shouldRun() function. All Types
changed which could lead to breaking changes on older versions of the actions
TEST PLAN:
Test in pull request

BREAKING CHANGE:
Possibly breaks configs. Verify your config
…ndum/release-mastermind): updates documentation
…endum/release-mastermind): update config

Signed-off-by: Jonathan Stevens <[email protected]>
…videndum/release-mastermind): misc Changes - Yarn.lock & action workflow
…videndum/release-mastermind): refactor the contextHandler.ts into ./src/contexts/ folder as static calls within classes

Closes: #198
Signed-off-by: Jonathan Stevens <[email protected]>
Copy link
Contributor

@VidendumStudios VidendumStudios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantic Conditions failed - Please title your pull request using one of the valid options:

Types: bug, chore, opt, optimisation, style, maint, maintenance, ref, refactor, revert, dep, deprecated, removal, docs, documentation, feat, enhance, feature, enhancement, fix

Contexts: @videndum/workflow-mastermind, @videndum/release-mastermind, @videndum/label-mastermind, @videndum/variable-mastermind, @videndum/convention-mastermind, condition, api, util, installer, deps, deps-dev


This message will be automatically updated when you make this change

Jonathan Stevens added 3 commits August 5, 2021 22:58
@TGTGamer TGTGamer changed the title feat(@videndum/release-mastermind)!: staleness, schedules and more feat(@videndum/release-mastermind): staleness, schedules and more Aug 5, 2021
@VidendumStudios VidendumStudios added the Size - XXL More than 1000 lines changed label Aug 5, 2021
@VidendumStudios VidendumStudios dismissed their stale review August 5, 2021 22:23

Conventions corrected - Review no longer required

@VidendumStudios VidendumStudios added DevOps - Rejected DevOPS wont continue Type - Feature A new feature Context - Release Mastermind Related to @resnovas/release-mastermind Status - Review Needed This pull request is waiting on review DevOps - Reviewing DevOPS awaiting review and removed DevOps - Rejected DevOPS wont continue labels Aug 5, 2021
@VidendumStudios VidendumStudios removed the DevOps - Reviewing DevOPS awaiting review label Aug 5, 2021
@Resnovas Resnovas deleted a comment from TGTGamer Aug 5, 2021
@Resnovas Resnovas deleted a comment from TGTGamer Aug 5, 2021
TGTGamer and others added 4 commits August 8, 2021 07:07
…videndum/release-mastermind): refactor the entire project to enable new docs

I have spent about an entire working day refactoring the entire project, to support typeDocs and
much more. I've also added a lot of documentation and setup a schema for the JSON files
@TGTGamer TGTGamer added this to the Summer Overhaul milestone Aug 8, 2021
@Resnovas Resnovas deleted a comment from madalenamelo Aug 8, 2021
@Resnovas Resnovas deleted a comment from madalenamelo Aug 8, 2021
@Resnovas Resnovas deleted a comment from madalenamelo Aug 8, 2021
@TGTGamer TGTGamer linked an issue Aug 8, 2021 that may be closed by this pull request
Jonathan Stevens added 2 commits August 8, 2021 17:39
Jonathan Stevens and others added 5 commits August 13, 2021 19:26
Drops support for all submodules which are extracted from main project. All functionality is now
renamed "smartcloud"

BREAKING CHANGE: Drops support for submodules
Signed-off-by: Jonathan Stevens <[email protected]>
Signed-off-by: Jonathan Stevens <[email protected]>
@TGTGamer TGTGamer merged commit 4f8cc4b into develop Sep 11, 2021
@TGTGamer TGTGamer deleted the feat/staleness branch September 11, 2021 14:26
@TGTGamer TGTGamer restored the feat/staleness branch September 11, 2021 14:27
TGTGamer added a commit that referenced this pull request Sep 11, 2021
…son schema, staleness, schedules and more #AM-1 (#203)"

This reverts commit 4f8cc4b.
@TGTGamer TGTGamer deleted the feat/staleness branch September 11, 2021 14:28
@TGTGamer TGTGamer restored the feat/staleness branch September 14, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Context - Release Mastermind Related to @resnovas/release-mastermind Size - XXL More than 1000 lines changed Status - Review Needed This pull request is waiting on review Type - Feature A new feature
Projects
None yet
2 participants