fix: resolve all compiler warnings#2
Merged
NoEgAm merged 2 commits intoSep 1, 2025
Conversation
added 2 commits
August 18, 2025 06:22
Fixed the following compiler warnings: - Replaced deprecated `fnalias x as y` syntax with `let y = x` for non-function aliases - Replaced deprecated `.or()` method calls with `.unwrap_or()` method calls - Removed unused functions: `JsValue::get_prop` and `JsValue::reinterpret_as_int` - Removed unused trait implementations: `Show` and `Eq` derives for Block and LineChunk enums - Removed unused `Show` implementation for Store struct - Removed unused `text_node` import from fnalias - Fixed pattern matching for Block::Empty case All warnings have been resolved and the project now compiles cleanly with --target js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was made by an LLM agent.
Fixed the following compiler warnings:
fnalias x as ysyntax withlet y = xfor non-function aliases.or()method calls with.unwrap_or()method callsJsValue::get_propandJsValue::reinterpret_as_intShowandEqderives for Block and LineChunk enumsShowimplementation for Store structtext_nodeimport from fnaliasAll warnings have been resolved and the project now compiles cleanly with --target js.