Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses warnings in the codebase by updating syntax and dependencies. The changes modernize the MoonBit syntax from older function call conventions to newer raise/throw semantics and update package versions.
- Updates function syntax from
!notation toraisekeyword for error handling - Modernizes string interpolation and function call syntax
- Updates dependencies to newer versions
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/store.mbt | Removes unused Show implementation for Store |
| src/main/main.mbt | Updates function syntax, removes unused imports, modernizes string interpolation |
| src/main/counter.mbt | Updates error handling syntax and event handling patterns |
| package.json | Updates vite dependency to version 7.0.3 |
| moon.mod.json | Updates respo dependency to version 0.0.35 |
| // @dom_ffi.log("store: " + app.store.val.to_json().stringify(indent=2)) | ||
| app.render_loop(fn() { view!(app.store.val) }, fn(op) { | ||
| @dom_ffi.log("Action: " + op.to_string()) | ||
| app.render_loop(fn() { view(app.store.val) }, fn(op) { |
There was a problem hiding this comment.
The PR title contains a spelling error: 'hanle' should be 'handle'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.