Skip to content

Conversation

@phuongdinh1411
Copy link

Hi @deruelle @brainslog , Can you please review the implementation for me?
Thank you so much for recommending me this issue.

@deruelle deruelle requested a review from brainslog January 9, 2017 14:13
@deruelle
Copy link
Member

deruelle commented Jan 9, 2017

Thanks @phuongdinh1411. @brainslog can you review ?

Copy link
Contributor

@brainslog brainslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @phuongdinh1411, thanks for this contribution.

I am not sure this is the best approach, it doesn't work fully for me, can you tell me how have you tested ?

In my understanding the best option would be to try to standardize the stack on the org.jdiameter.api.EventListener.timeoutExpired(Request) method, to deliver the timeout message to the context, eg: in case of the ClientAcc, it sends an event of type FAILED_SEND_RECORD and after that calls the context.failedSendRecord method on the context (which would be the RA)

This likely might need to be discussed and customized on a application basis, otherwise we'll have multiple callbacks, because other diameter apps have higher level callbacks (eg: Client CCA), others move to a TIMED_OUT state (eg: S6a), etc...

Thoughts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants