Skip to content

Fix building MAME on rpi3 with 32bit arm userland and aarch64 kernel #4027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Fix building MAME on rpi3 with 32bit arm userland and aarch64 kernel #4027

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3d5ad2
mame - fix rpi3 build on 32bit arm userland with aarch64 kernel
joolswills Jan 23, 2025
e3e1d6e
mame - disable distcc
joolswills Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions scriptmodules/emulators/mame.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ rp_module_help="ROM Extensions: .zip .7z\n\nCopy your MAME roms to either $romdi
rp_module_licence="GPL2 https://raw.githubusercontent.com/mamedev/mame/master/COPYING"
rp_module_repo="git https://github.com/mamedev/mame.git :_get_branch_mame"
rp_module_section="exp"
rp_module_flags="!mali !armv6 !:\$__gcc_version:-lt:7"
rp_module_flags="!mali !armv6 !:\$__gcc_version:-lt:7 nodistcc"

function _get_branch_mame() {
# starting with 0.265, GCC 10.3 or later is required for full C++17 support
Expand Down Expand Up @@ -52,8 +52,26 @@ function build_mame() {

local params=(NOWERROR=1 ARCHOPTS="-U_FORTIFY_SOURCE -Wl,-s" PYTHON_EXECUTABLE=python3 OPTIMIZE=2 USE_SYSTEM_LIB_FLAC=1)
isPlatform "x11" && params+=(USE_QTDEBUG=1) || params+=(USE_QTDEBUG=0)

# array for storing ARCHOPTS_CXX parameters
local arch_opts_cxx=()

# when building on ARM enable 'fsigned-char' for compiled code, fixes crashes in a few drivers
isPlatform "arm" || isPlatform "aarch64" && params+=(ARCHOPTS_CXX=-fsigned-char)
isPlatform "arm" || isPlatform "aarch64" && arch_opts_cxx+=(-fsigned-char)

# workaround g++-12 compiler bug/compilation issue on 32bit arm userland with aarch64 kernel on the rpi3 (cortex-a53)
# disabling -ftree-slp-vectorize works around the issue:
# {standard input}: Assembler messages:
# {standard input}:4045: Error: co-processor offset out of range
# make[2]: *** [skeleton.make:2727: obj/Release/src/mame/skeleton/scopus.o] Error 1
if [[ "$__gcc_version" -eq 12 ]] && isPlatform "rpi3" && isPlatform "32bit" && [[ "$(uname -m)" == "aarch64" ]]; then
arch_opts_cxx+=(-fno-tree-slp-vectorize)
fi

# if we have any arch opts set, add them
if [[ ${#arch_opts_cxx[@]} -gt 0 ]]; then
params+=(ARCHOPTS_CXX="${arch_opts_cxx[*]}")
fi

# force arm on arm platform - fixes building mame on when using 32bit arm userland with aarch64 kernel
isPlatform "arm" && params+=(PLATFORM=arm)
Expand Down