Fix chameleon_cli_unit.check_tools check the wrong dir#308
Closed
azuwis wants to merge 1 commit intoRfidResearchGroup:mainfrom
Closed
Fix chameleon_cli_unit.check_tools check the wrong dir#308azuwis wants to merge 1 commit intoRfidResearchGroup:mainfrom
azuwis wants to merge 1 commit intoRfidResearchGroup:mainfrom
Conversation
Commit 35d2f40 introduce a breaking change, `chameleon_cli_unit.check_tools` check `bin` dir from pwd, instead of `bin` dir in the same dir of `chameleon_cli_unit.py`. `python3 ./software/script/chameleon_cli_main.py` outputs wrong warning: ``` Warning, ... not found. Corresponding commands will not work as intended ```
|
You are welcome to add an entry to the CHANGELOG.md as well |
Built artifacts for commit c14e6ccFirmwareClient |
Contributor
Author
|
Close in favor of #317 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 35d2f40 introduce a breaking change,
chameleon_cli_unit.check_toolscheckbindir from pwd, instead ofbindir in the same dir ofchameleon_cli_unit.py.python3 ./software/script/chameleon_cli_main.pyoutputs wrong warning: