Skip to content

Added FIELD_OFF_DO_RESET support to cli hf mf econfig#342

Merged
xianglin1998 merged 2 commits intoRfidResearchGroup:mainfrom
tommiv:cli-field-off-reset
Feb 2, 2026
Merged

Added FIELD_OFF_DO_RESET support to cli hf mf econfig#342
xianglin1998 merged 2 commits intoRfidResearchGroup:mainfrom
tommiv:cli-field-off-reset

Conversation

@tommiv
Copy link

@tommiv tommiv commented Jan 30, 2026

Adds CLI support for ca74327

Usage

hf mf econfig --slot 1 --enable_set_field_off_do_reset
hf mf econfig --slot 1 --disable_set_field_off_do_reset
image

@github-actions
Copy link

You are welcome to add an entry to the CHANGELOG.md as well

Copy link
Contributor

@GameTec-live GameTec-live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM? Would still need someone else to test, but other than that...

@GameTec-live GameTec-live added the testme! This PR is ready but just missing tests. Join in and help testing! label Jan 30, 2026
@xianglin1998
Copy link
Contributor

I can do test...

@xianglin1998
Copy link
Contributor

After testing, it works very well. Thanks for your code/view.
@tommiv @GameTec-live

The command needs to be shortened, and some words can be deleted.

hf mf econfig --slot 1 --enable_field_off_do_reset
hf mf econfig --slot 1 --disable_field_off_do_reset

no 'set' word i think it's well. Haha, you can update for this change, we will merge it. 👍

@tommiv

@tommiv tommiv force-pushed the cli-field-off-reset branch from 80280d9 to 613987b Compare February 2, 2026 10:21
@tommiv
Copy link
Author

tommiv commented Feb 2, 2026

@xianglin1998 updated, thank you.

@xianglin1998 xianglin1998 merged commit eeaca16 into RfidResearchGroup:main Feb 2, 2026
7 of 9 checks passed
@xianglin1998
Copy link
Contributor

Merged

@YuyangisCoding
Copy link
Contributor

YuyangisCoding commented Feb 3, 2026

This PR breaks hf mf econfig command

[USB] chameleon --> hf mf econfig -s 1
CLI exception: Traceback (most recent call last):
  File "chameleon_cli_main.py", line 146, in exec_cmd
  File "chameleon_cli_main.py", line 141, in exec_cmd
  File "chameleon_cli_unit.py", line 2266, in on_exec
AttributeError: 'Namespace' object has no attribute 'enable_set_field_off_do_reset'. Did you mean: 'enable_field_off_do_reset'?

I fixed it in PR #346

@tommiv
Copy link
Author

tommiv commented Feb 3, 2026

@YuyangisCoding my bad. We shortened flags the last moment and I didn't test it thoroughly because what could have gone wrong. Added a PR with hotfix: #348

UPD: apparently github doesn't send emails if the comment was edited and I haven't seen you've already created a PR. I'll close mine as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testme! This PR is ready but just missing tests. Join in and help testing!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants