Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in dev branch to main branch #87

Merged
merged 104 commits into from
Dec 30, 2024
Merged

Bring in dev branch to main branch #87

merged 104 commits into from
Dec 30, 2024

Conversation

Rinzii
Copy link
Owner

@Rinzii Rinzii commented Dec 28, 2024

This pr brings in a bunch of minor and major fixes including adding significantly more aggressive warnings and also improvements to both the cmake and the CI.

We also fix many different bugs throughout the code base that were effecting our downstream customers.

We've also deprecated avx512 completely as it has a major bug in it with msvc that was not solvable and since avx512 support in general is quite limited I found it was worth removing completely.

More work still needs to be done, but for the time being I feel it is worthwhile bringing these changes into the main to ensure people don't have the above listed issues.

@Rinzii Rinzii requested a review from nekoflare December 29, 2024 11:36
@Rinzii
Copy link
Owner Author

Rinzii commented Dec 29, 2024

Ready for review.

lint.bat Outdated Show resolved Hide resolved
@Rinzii
Copy link
Owner Author

Rinzii commented Dec 29, 2024

Gave comments on comments given and finished implementing the remainder of the builtin section for gcc.

@Rinzii Rinzii requested a review from nekoflare December 29, 2024 21:07
@Rinzii Rinzii requested review from nekoflare and removed request for nekoflare December 29, 2024 22:10
Copy link
Collaborator

@nekoflare nekoflare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this code, I learned more too and everything seems to be alright

@Rinzii Rinzii requested a review from nekoflare December 30, 2024 21:12
Copy link
Collaborator

@nekoflare nekoflare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Seems all alright

@Rinzii Rinzii merged commit a81a080 into main Dec 30, 2024
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants