-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring in dev branch to main branch #87
Conversation
Signed-off-by: Ian <[email protected]>
Signed-off-by: Ian <[email protected]>
Signed-off-by: Ian <[email protected]>
Signed-off-by: Ian <[email protected]>
Ready for review. |
Signed-off-by: Ian <[email protected]>
Gave comments on comments given and finished implementing the remainder of the builtin section for gcc. |
Signed-off-by: Ian <[email protected]>
Signed-off-by: Ian <[email protected]>
…ur compiler on clang Signed-off-by: Ian <[email protected]>
…g handles bit_cast Signed-off-by: Ian <[email protected]>
Signed-off-by: Ian <[email protected]>
Signed-off-by: Ian <[email protected]>
Signed-off-by: Ian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this code, I learned more too and everything seems to be alright
Signed-off-by: Ian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Seems all alright
This pr brings in a bunch of minor and major fixes including adding significantly more aggressive warnings and also improvements to both the cmake and the CI.
We also fix many different bugs throughout the code base that were effecting our downstream customers.
We've also deprecated avx512 completely as it has a major bug in it with msvc that was not solvable and since avx512 support in general is quite limited I found it was worth removing completely.
More work still needs to be done, but for the time being I feel it is worthwhile bringing these changes into the main to ensure people don't have the above listed issues.