Skip to content

Conversation

@akshath3001
Copy link

Overview

We need the Django REST framework for Week-2 tasks(involving building REST APIs).
Code formatter and linter support was missing for python/backend. Ruff is the recommended Python formatter/linter.

Changes

  • Add djangorestframework in backend dependencies
  • Add charliermarsh.ruff to recommend VS Code extensions
  • Configure the ruff formatter VS Code extensions

Reference

Django REST Framework: link
Ruff: link

Copy link

@chirgjn chirgjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll let other folks chime in before we merge

Copy link

@rohanprabhu rohanprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make changes in README that outline - how to use the lint tool, and that DRF is included in the starter project. Rest lgtm!

@akshath3001
Copy link
Author

I have made the necessary changes in the README file. Although, despite using the command git config --global core.autocrlf true, some unnecessary spaces were included in README. The command was used against the following error warning: in the working copy of 'README.md', LF will be replaced by CRLF the next time Git touches it.
I request you to guide me on this.
Thanks

@rohanprabhu
Copy link

I have made the necessary changes in the README file. Although, despite using the command git config --global core.autocrlf true, some unnecessary spaces were included in README. The command was used against the following error warning: in the working copy of 'README.md', LF will be replaced by CRLF the next time Git touches it. I request you to guide me on this. Thanks

@akshath3001 - can you check your editor settings and try to get the CRLFs back to simple LFs - since this is an upstream merge, we want to make sure that all files are conventionally solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants