Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS Cipher header #1

Merged
merged 13 commits into from
Jul 26, 2024
Merged

Add TLS Cipher header #1

merged 13 commits into from
Jul 26, 2024

Conversation

jadolg
Copy link
Member

@jadolg jadolg commented Jul 23, 2024 •
edited
Loading

Ticket: OP-2637

Description

This plugin takes TLS information and stores it in the request headers.
This PR sets the base to do so and takes care of setting the cipher used by the connection.

How has this been tested

  1. Execute the headers reader web service make start_headers_reader
  2. Execute traefik with the plugin locally loaded make testcontainer
  3. Make a request to traefik curl https://localhost -k
    The response should contain a non-empty X-Tls-Cipher header.

@jadolg jadolg requested review from applejag and RI-Kai July 23, 2024 10:16
applejag
applejag requested changes Jul 26, 2024
View reviewed changes
.assets/icon.png Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
plugin.go Outdated Show resolved Hide resolved
applejag
applejag requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@applejag applejag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: canonicalize the header name

testconfig/dynamic.yml Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
plugin_test.go Outdated Show resolved Hide resolved
.traefik.yml Outdated Show resolved Hide resolved
@jadolg jadolg requested a review from applejag July 26, 2024 12:58
applejag
applejag approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@applejag applejag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jadolg jadolg merged commit e6c49d0 into master Jul 26, 2024
7 checks passed
@jadolg jadolg deleted the op-2637/add-tls-cipher-header branch July 26, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@applejag applejag applejag approved these changes

@RI-Kai RI-Kai Awaiting requested review from RI-Kai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jadolg @applejag