Skip to content

matchDiscourseNode early return for single "has title" clause #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdroidian merged 1 commit into from
Dec 4, 2024
Merged

matchDiscourseNode early return for single "has title" clause #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/utils/matchDiscourseNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,23 @@ const matchDiscourseNode = ({
}
| { uid: string }
)) => {
// Handle specification with single "has title" clause
if (
specification.length === 1 &&
specification[0].type === "clause" &&
specification[0].relation === "has title"
) {
const title =
"title" in rest ? rest.title : getPageTitleByPageUid(rest.uid);
const regex = new RegExp(specification[0].target.slice(1, -1));
return !specification[0].not && regex.test(title);
}

// Handle any other specification
if (specification.length) {
const where = replaceDatalogVariables(
[{ from: text, to: "node" }],
specification.flatMap((c) =>
conditionToDatalog(c)
)
specification.flatMap((c) => conditionToDatalog(c))
).map((c) => compileDatalog(c, 0));
const firstClause =
"title" in rest
Expand All @@ -35,6 +46,8 @@ const matchDiscourseNode = ({
`[:find ?node :where ${firstClause} ${where.join(" ")}]`
).length;
}

// Fallback to format expression
const title = "title" in rest ? rest.title : getPageTitleByPageUid(rest.uid);
return getDiscourseNodeFormatExpression(format).test(title);
};
Expand Down
Loading