-
Notifications
You must be signed in to change notification settings - Fork 7
Expand Datalog predicate expression coverage (Closes #49) #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Datalog predicate expression coverage (Closes #49) #51
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related issues
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/types/native.ts(1 hunks)
🔇 Additional comments (1)
src/types/native.ts (1)
142-142: Clarify the distinction betweenpredandfnfor overlapping operators.Both
get(line 142) andre-pattern(line 150) appear in theDatalogPredExpr.predunion, but they also exist inDatalogFnExpr.fn(line 167).Please clarify:
- When should these be used as predicates vs. functions?
- Is the distinction that
DatalogFnExprincludes explicit binding whileDatalogPredExprdoes not?Understanding this will help ensure correct usage throughout the codebase.
Also applies to: 150-150, 167-167
…ps://github.com/RoamJS/roamjs-components into codex/add-missing-predicates-to-datalogpredexpr
Summary
Testing
Codex Task
Summary by CodeRabbit
New Features
Chores