Skip to content

Implement fuzzy search for attribute selection in popover component #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdroidian merged 1 commit into from
Apr 27, 2025
Merged

Implement fuzzy search for attribute selection in popover component #501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/features/attributeSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import { render as renderToast } from "roamjs-components/components/Toast";
import setInputSetting from "roamjs-components/util/setInputSetting";
import setInputSettings from "roamjs-components/util/setInputSettings";
import getSettingValueFromTree from "roamjs-components/util/getSettingValueFromTree";
import fuzzy from "fuzzy";

const CONFIG = `roam/js/attribute-select`;

Expand Down Expand Up @@ -122,9 +123,6 @@ const AttributeButtonPopover = <T extends ReactText>({
filterable = false,
isOpen,
}: AttributeButtonPopoverProps<T>) => {
const itemPredicate = (query: string, item: T) => {
return String(item).toLowerCase().includes(query.toLowerCase());
};
const [sliderValue, setSliderValue] = useState(0);

useEffect(() => {
Expand Down Expand Up @@ -182,7 +180,17 @@ const AttributeButtonPopover = <T extends ReactText>({
return (
<MenuItemSelect
className="inline-menu-item-select"
itemPredicate={itemPredicate}
itemListPredicate={(query: string, items: T[]) => {
if (!query) return items;
const stringItems = items.map(String);
const results = fuzzy
.filter(query, stringItems)
.map((f) => items[stringItems.indexOf(f.original)]);
if (results.length > 50) {
return results.slice(0, 50).concat("Only first 50 shown ..." as T);
}
return results;
}}
items={items}
activeItem={currentValue as T}
filterable={shouldFilter}
Expand Down