-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Lutris API Client #42
base: master
Are you sure you want to change the base?
Conversation
Function rewrite
# Conflicts: # default.py
Created resources/lib folder Moved lutrisapi.py file to lib folder Created lutriscmd.py file - Object to interact with the commandline interface of Lutris Created helper.py file - File to hold helper functions Incorporated @solbero function_rewrite branch Included the Lutris.net Username and Password field in settings.xml Extended the require section in the addon.xml
First version of functional API implementation
The API Client is now functional, testing still has to be done. infoLabels don't get yet displayed |
@@ -10,7 +10,7 @@ | |||
<import addon="script.module.simplejson" version="3.16.1"/> | |||
</requires> | |||
<extension point="xbmc.python.pluginsource" library="default.py"> | |||
<provides>executable</provides> | |||
<provides>game executable</provides> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addon should provide game
.
The extension has an additional child element named , which contains a whitespace separated list of image, video, audio, and/or executable. This determines in what area (or context) of the Kodi system your addon will make itself visible in (please note that this applies only to plugin extension points):
If both executable
and game
is included in the <provides>
tag the addon shows up in both “Games” and “Programs” menu in Kodi. However, the addon will not construct a list item if called from “Programs” if xbmcplugin.setContent(handle, content)
is set to games
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I will change that!
@@ -24,38 +27,22 @@ | |||
addon_settings = xbmcaddon.Addon(id='script.lutris') | |||
# Get the addon name from addon settings | |||
addon_name = addon_settings.getAddonInfo('name') | |||
# Plugin User Data Folder | |||
userdata = addon_settings.getAddonInfo('path') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be decoded from UTF-8. See Add-on unicode paths for more information on how Kodi handles unicode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the resource.. Didn't know about that but makes sense if path contains other chars
Very nice work! Looking forward to testing it. |
I have posted a question on the Kodi addon development forum: https://forum.kodi.tv/showthread.php?tid=344941 |
@solbero Do you want to keep your functions like |
Move them as you see fit. I agree with you on keeping default.py as small
as possible.
|
Added TODO tasks
Lutris.net API Documentation