-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for React 19 #56
base: master
Are you sure you want to change the base?
Conversation
@RobPethick can you take a look at this? Seems like many folks are interested. Thanks! |
@RobPethick Can we borrow 5 minutes of your time to hit that merge button? |
I guess it's time for a React-custom-scrollbars-3 |
Name already hoisted: https://www.npmjs.com/package/react-custom-scrollbars-3 I can give it a go with a quick publish of this commit. This project needs some love as well (migrate to native TypeScript instead of static type definitions, migrate to functional components, self-publish via GitHub Actions come to mind), sounds pretty fun to me. Not sure if |
Ok, just released react-custom-scrollbars-4 @ v4.5.1, cherry-picking 0ff4d8c and added a GitHub Actions workflow for transparency during build & publishing. v4.5.1 run here. I'll give it some more love during the weekend 😄 |
Looking good @barrenechea. Thanks for doing this. Will make the switch over the weekend. Happy to try to contribute if I can in the future 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please merge this PR. I need this package in the latest version as I am using Node.js version 20.12.2. |
this is also not working |
@dhruvsemicolon |
TY @AKiranB, I honestly have no words for what just happened...
|
Add support for React 19