Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for React 19 #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

marcauberer
Copy link

Add support for React 19

@Wiktor102 Wiktor102 mentioned this pull request Dec 28, 2024
@marcauberer
Copy link
Author

@RobPethick can you take a look at this? Seems like many folks are interested. Thanks!

@tutturen
Copy link

@RobPethick Can we borrow 5 minutes of your time to hit that merge button?

@AKiranB
Copy link

AKiranB commented Feb 14, 2025

I guess it's time for a React-custom-scrollbars-3

@barrenechea
Copy link

barrenechea commented Feb 14, 2025

I guess it's time for a React-custom-scrollbars-3

Name already hoisted: https://www.npmjs.com/package/react-custom-scrollbars-3
It does not give me a lot of confidence, tbh. And no React 19 support either.

I can give it a go with a quick publish of this commit. This project needs some love as well (migrate to native TypeScript instead of static type definitions, migrate to functional components, self-publish via GitHub Actions come to mind), sounds pretty fun to me.

Not sure if react-custom-scrollbars-4 would be okay, though 😆 kinda hate placing numbers within the package name, but at least people could associate it that way...

@barrenechea
Copy link

Ok, just released react-custom-scrollbars-4 @ v4.5.1, cherry-picking 0ff4d8c and added a GitHub Actions workflow for transparency during build & publishing. v4.5.1 run here.

I'll give it some more love during the weekend 😄

@AKiranB
Copy link

AKiranB commented Feb 14, 2025

Looking good @barrenechea. Thanks for doing this. Will make the switch over the weekend. Happy to try to contribute if I can in the future 🙏

Copy link

@ebrayce ebrayce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhruvsemicolon
Copy link

Please merge this PR. I need this package in the latest version as I am using Node.js version 20.12.2.

@dhruvsemicolon
Copy link

dhruvsemicolon commented Mar 26, 2025

I guess it's time for a React-custom-scrollbars-3

Name already hoisted: https://www.npmjs.com/package/react-custom-scrollbars-3 It does not give me a lot of confidence, tbh. And no React 19 support either.

I can give it a go with a quick publish of this commit. This project needs some love as well (migrate to native TypeScript instead of static type definitions, migrate to functional components, self-publish via GitHub Actions come to mind), sounds pretty fun to me.

Not sure if react-custom-scrollbars-4 would be okay, though 😆 kinda hate placing numbers within the package name, but at least people could associate it that way...

this is also not working
it says
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/react
npm error react@"^19.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer react@"^0.14.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0" from [email protected]

@AKiranB
Copy link

AKiranB commented Mar 26, 2025

@dhruvsemicolon
Before you start giving thumbs down on peoples comments - did you even spend 30 seconds to actually read this thread?
React custom scrollbars 3 just points to this repository, as we speak about right above this comment.

@barrenechea
Copy link

@dhruvsemicolon Before you start giving thumbs down on peoples comments - did you even spend 30 seconds to actually read this thread? React custom scrollbars 3 just points to this repository, as we speak about right above this comment.

TY @AKiranB, I honestly have no words for what just happened...

I guess it's time for a React-custom-scrollbars-3

Name already hoisted: https://www.npmjs.com/package/react-custom-scrollbars-3 It does not give me a lot of confidence, tbh. And no React 19 support either.
I can give it a go with a quick publish of this commit. This project needs some love as well (migrate to native TypeScript instead of static type definitions, migrate to functional components, self-publish via GitHub Actions come to mind), sounds pretty fun to me.
Not sure if react-custom-scrollbars-4 would be okay, though 😆 kinda hate placing numbers within the package name, but at least people could associate it that way...

this is also not working it says npm error While resolving: [email protected] npm error Found: [email protected] npm error node_modules/react npm error react@"^19.0.0" from the root project npm error npm error Could not resolve dependency: npm error peer react@"^0.14.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0" from [email protected]

facepalm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants