Skip to content

feat(back): create packages for ROS2 exec #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KelianHalleray wants to merge 1 commit into
base: development
Choose a base branch
from
Open

feat(back): create packages for ROS2 exec #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added src/robocoop_backend/robocoop_backend/__init__.py
View file
Open in desktop
Empty file.
Empty file added src/robocoop_backend/robocoop_backend/tests/fixtures/__init__.py
View file
Open in desktop
Empty file.
Empty file added src/robocoop_backend/robocoop_backend/tests/integration/__init__.py
View file
Open in desktop
Empty file.
Empty file added src/robocoop_backend/robocoop_backend/tests/unit/__init__.py
View file
Open in desktop
Empty file.
17 changes: 17 additions & 0 deletions src/robocoop_backend/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
from setuptools import find_packages, setup

setup(
name="robocoop_backend",
version="0.1.0",
packages=find_packages(exclude=["tests*"]),
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find_packages(exclude=["tests*"]) will not exclude robocoop_backend.tests... because the pattern only matches packages that start with tests. As a result, the test packages are likely to be included in the distribution; use an exclude pattern like robocoop_backend.tests* (or drop the exclude if you intend to ship tests).

Suggested change
packages=find_packages(exclude=["tests*"]),
packages=find_packages(exclude=["robocoop_backend.tests*"]),

Copilot uses AI. Check for mistakes.
install_requires=[
"websockets",
"pyyaml",
],
extras_require={
"ros": ["rclpy"],
},
python_requires=">=3.10",
description="Robocoop WebSocket backend.",
license="Apache-2.0",
)
11 changes: 11 additions & 0 deletions src/robocoop_bringup/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
cmake_minimum_required(VERSION 3.8)
project(robocoop_bringup)

find_package(ament_cmake REQUIRED)

install(
DIRECTORY launch config scripts
DESTINATION share/${PROJECT_NAME}
)

Comment on lines +7 to +10
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install(DIRECTORY ... scripts ...) may install the shell scripts without executable permissions depending on source file modes. If these are meant to be runnable entrypoints, prefer install(PROGRAMS scripts/*.sh DESTINATION lib/${PROJECT_NAME}) (or similar) to ensure they are executable after installation.

Suggested change
DIRECTORY launch config scripts
DESTINATION share/${PROJECT_NAME}
)
DIRECTORY launch config
DESTINATION share/${PROJECT_NAME}
)
install(
PROGRAMS scripts/*.sh
DESTINATION lib/${PROJECT_NAME}
)

Copilot uses AI. Check for mistakes.
ament_package()
0 ...bocoop_bringup/config/backend.params.yaml → ...bocoop_bringup/config/backend.params.yaml
View file
Open in desktop
File renamed without changes.
0 ...obocoop_bringup/config/common.params.yaml → ...obocoop_bringup/config/common.params.yaml
View file
Open in desktop
File renamed without changes.
0 ...robocoop_bringup/config/m3pro_topics.yaml → ...robocoop_bringup/config/m3pro_topics.yaml
View file
Open in desktop
File renamed without changes.
0 .../robocoop_bringup/config/mock.params.yaml → src/robocoop_bringup/config/mock.params.yaml
View file
Open in desktop
File renamed without changes.
0 .../robocoop_bringup/config/real.params.yaml → src/robocoop_bringup/config/real.params.yaml
View file
Open in desktop
File renamed without changes.
0 ...ocoop_bringup/config/security.params.yaml → ...ocoop_bringup/config/security.params.yaml
View file
Open in desktop
File renamed without changes.
0 ...d/robocoop_bringup/config/sim.params.yaml → src/robocoop_bringup/config/sim.params.yaml
View file
Open in desktop
File renamed without changes.
0 ...op_bringup/launch/backend_debug.launch.py → ...op_bringup/launch/backend_debug.launch.py
View file
Open in desktop
File renamed without changes.
0 ...oop_bringup/launch/backend_mock.launch.py → ...oop_bringup/launch/backend_mock.launch.py
View file
Open in desktop
File renamed without changes.
0 ...oop_bringup/launch/backend_real.launch.py → ...oop_bringup/launch/backend_real.launch.py
View file
Open in desktop
File renamed without changes.
0 ...coop_bringup/launch/backend_sim.launch.py → ...coop_bringup/launch/backend_sim.launch.py
View file
Open in desktop
File renamed without changes.
0 ...ngup/launch/includes/monitoring.launch.py → ...ngup/launch/includes/monitoring.launch.py
View file
Open in desktop
File renamed without changes.
0 ...p/launch/includes/robot_runtime.launch.py → ...p/launch/includes/robot_runtime.launch.py
View file
Open in desktop
File renamed without changes.
0 ...gup/launch/includes/ros_bridges.launch.py → ...gup/launch/includes/ros_bridges.launch.py
View file
Open in desktop
File renamed without changes.
0 ...ingup/launch/includes/websocket.launch.py → ...ingup/launch/includes/websocket.launch.py
View file
Open in desktop
File renamed without changes.
16 changes: 16 additions & 0 deletions src/robocoop_bringup/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?xml version="1.0"?>
<package format="3">
<n>robocoop_bringup</n>
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.xml uses <n> instead of the required <name> tag. This makes the manifest invalid and will cause ROS2 tooling (colcon/ament) to fail parsing the package.

Suggested change
<n>robocoop_bringup</n>
<name>robocoop_bringup</name>

Copilot uses AI. Check for mistakes.
<version>0.1.0</version>
<description>Launch files and parameter configs for Robocoop.</description>
<maintainer>Robocoop Team</maintainer>
Comment on lines +3 to +6
Copy link
Copy Markdown

@qodo-code-review qodo-code-review Bot Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Broken package.xml manifest 🐞 Bug ≡ Correctness

src/robocoop_bringup/package.xml uses an invalid tag (<n> instead of <name>) and declares a
<maintainer> without the required email attribute, which will prevent ROS2 tooling (ament/colcon)
from parsing/building the package. This blocks building/using robocoop_bringup in the repo’s ROS2
environment.
Agent Prompt 
## Issue description
`src/robocoop_bringup/package.xml` is not valid for ROS2 tooling because it uses `<n>` instead of `<name>` and the maintainer tag omits the required `email` attribute.

## Issue Context
This will prevent `ament/colcon` from parsing the package manifest, blocking builds and installs.

## Fix Focus Areas
- src/robocoop_bringup/package.xml[1-8]

## Suggested change
- Replace `<n>robocoop_bringup</n>` with `<name>robocoop_bringup</name>`
- Change maintainer to include email, e.g. `<maintainer email="[email protected]">Robocoop Team</maintainer>` (use the real email)

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<maintainer> is missing the required email attribute (e.g., <maintainer email="...">...). Many ROS2/ament checks treat this as an error, and it also makes it hard for users to contact the maintainer.

Suggested change
<maintainer>Robocoop Team</maintainer>
<maintainer email="[email protected]">Robocoop Team</maintainer>

Copilot uses AI. Check for mistakes.
<license>Apache-2.0</license>

<buildtool_depend>ament_cmake</buildtool_depend>

<exec_depend>rclpy</exec_depend>
<exec_depend>geometry_msgs</exec_depend>
<exec_depend>nav_msgs</exec_depend>
<exec_depend>sensor_msgs</exec_depend>
<exec_depend>std_msgs</exec_depend>
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bringup package contains Python launch files, but package.xml does not declare runtime dependencies on launch/launch_ros. Without these, rosdep may not install the required launch system packages when building from source.

Suggested change
<exec_depend>std_msgs</exec_depend>
<exec_depend>std_msgs</exec_depend>
<exec_depend>launch</exec_depend>
<exec_depend>launch_ros</exec_depend>

Copilot uses AI. Check for mistakes.
</package>
0 ...kend/robocoop_bringup/scripts/run_mock.sh → src/robocoop_bringup/scripts/run_mock.sh
View file
Open in desktop
File renamed without changes.
0 ...kend/robocoop_bringup/scripts/run_real.sh → src/robocoop_bringup/scripts/run_real.sh
View file
Open in desktop
File renamed without changes.
0 ...ckend/robocoop_bringup/scripts/run_sim.sh → src/robocoop_bringup/scripts/run_sim.sh
View file
Open in desktop
File renamed without changes.