Feat/implement dashboard v0#6
Merged
damnthonyy merged 7 commits intodevelopfrom Mar 15, 2026
Merged
Conversation
Member
Author
|
/review |
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Member
Author
|
/improve |
|
Persistent review updated to latest commit daaa909 |
…vent listener in carousel.tsx ( #5 ) Co-authored-by: Antoine <[email protected]>
KelianHalleray
approved these changes
Mar 15, 2026
Review Summary by QodoDashboard v0: Complete UI component library and robot control dashboard
WalkthroughsDescription• **Complete UI component library**: 50+ reusable UI components built with Radix UI, Recharts, and other libraries (buttons, cards, forms, dialogs, menus, navigation, etc.) • **Dashboard v0 implementation**: Main dashboard page with integrated modules for robot control (manual control, camera feed, task management, metrics/alerts) • **Design system**: Comprehensive theme with CSS custom properties, color palette (primary, secondary, destructive, success, warning), and Tailwind configuration • **Robot control features**: Manual control module with autonomy toggle, speed slider, directional buttons, and emergency stop; task manager with delivery/guidance tabs; metrics and alerts display with battery chart • **Responsive design**: Mobile detection hook, sidebar with mobile sheet integration, responsive grid layouts • **Accessibility improvements**: ARIA labels, keyboard navigation, semantic HTML, proper form handling with react-hook-form • **Dependencies**: Added 40+ packages for UI components, form handling, animations, and charting • **Build improvements**: Updated lint scripts and ESLint configuration Diagramflowchart LR
A["UI Components<br/>50+ components"] --> B["Dashboard Page"]
C["Design System<br/>Theme & tokens"] --> B
D["Dashboard Modules<br/>Manual Control<br/>Camera Feed<br/>Task Manager<br/>Metrics/Alerts"] --> B
E["Dependencies<br/>Radix UI, Recharts<br/>react-hook-form"] --> A
E --> D
B --> F["Robot Control<br/>Interface"]
File Changes1. src/components/ui/use-mobile.ts
|
Code Review by Qodo
1. Button implicit submit type
|
Member
Author
|
@KelianHalleray im waiting for you to init the server for remove the first mock |
Comment on lines
+40
to
+48
| const Button = React.forwardRef<HTMLButtonElement, ButtonProps>( | ||
| ({ className, variant, size, asChild = false, ...props }, ref) => { | ||
| const Comp = asChild ? Slot : 'button'; | ||
| return ( | ||
| <Comp | ||
| className={cn(buttonVariants({ variant, size, className }))} | ||
| ref={ref} | ||
| {...props} | ||
| /> |
There was a problem hiding this comment.
1. Button implicit submit type 🐞 Bug ✓ Correctness
Button renders a native <button> without setting type, so when used inside a <form> it defaults to submit and can trigger unintended form submissions. This can cause incorrect navigation/data submission when buttons are intended to be non-submitting UI controls.
Agent Prompt
### Issue description
The shared `Button` component renders a native `<button>` without a default `type`, which can cause unintended form submissions.
### Issue Context
This component will be reused broadly; the safest default is `type="button"` unless the user explicitly sets `type` (or uses `asChild`).
### Fix Focus Areas
- src/components/ui/button.tsx[40-48]
### Implementation notes
- When `Comp === 'button'` and `props.type` is `undefined`, pass `type="button"`.
- Preserve any explicit `type` passed by the caller.
- Do not set `type` when `asChild` is true (since the underlying element may not be a button).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
feature
Summary
Dashboard v0 for Robocoop: UI components and main dashboard screen.
Description
globals.css, accessibility and typing fixes (readonly props, carouselsection/aria-label, contextuseMemo,ComponentRef).pnpm dev→ check header, camera, manual control, task/metrics/alert tabs, battery chart.What's Changed
Screen
Will
Relates to #5
Closes #5