Add Emscripten-wasm32 target #268
Conversation
Co-authored-by: Michael Batchelor <[email protected]>
…le-examples-rclcpp-minimal-publisher.emscripten.patch
…ble-examples-rclcpp-minimal-subscriber.emscripten.patch
…ents.emscripten.patch
|
Do you mind taking another look please @traversaro? |
| git: https://github.com/Tobias-Fischer/rmw_wasm | ||
| branch: emscripten-async-fixes | ||
| target_directory: ros-humble-rmw-wasm-cpp/src/work |
There was a problem hiding this comment.
This is a branch (not a tag or commit) and it is on a fork. As I guess this is a work in progress, if you confirm that this is intended it is ok for me.
There was a problem hiding this comment.
Very good catch! We'll open a pull request against upstream and then update once that's merged.
|
Thanks, I added some comments but mostly minor. My only remaining doubt is if the wasm-related additional recipes are meant to be build on target platforms different from emscripten32 . Could it make sense to add a dummy change to |
You are absolutely right, good catch. I've added |
|
Great, thanks! |
Hi @traversaro @wolfv - this PR implement the changes to rebuild emscripten-wasm32 packages for ros-humble. This is the second and last pull request that relies on the changes on vinca implemented on RoboStack/vinca#73, in addition to the implementation of the corresponding CI pipelines https://github.com/nmarticorena/ros-humble/actions/runs/13779961774 and all the various patches. All the changes were tested and uploaded to my personal Anaconda channel, https://anaconda.org/nmarticorena. With the rebuild of the Jupyter-Lite demo available at: https://nmarticorena.github.io/pixi-wasm/lab/index.html and the source code https://github.com/nmarticorena/pixi-wasm.
It would be great if you could review :).
Best, @Tobias-Fischer and @nmarticorena