Skip to content

fixed question builder row issue, fixed UI minor issue, TRAPI issue#22

Merged
Woozl merged 1 commit intomainfrom
updates/minor-fixes
Mar 23, 2026
Merged

fixed question builder row issue, fixed UI minor issue, TRAPI issue#22
Woozl merged 1 commit intomainfrom
updates/minor-fixes

Conversation

@Amaru333
Copy link
Copy Markdown
Collaborator

This pull request primarily standardizes code style by converting all string literals to use double quotes instead of single quotes and refactors some logic for consistency and clarity. It also fixes the data passed to the DownloadDialog for query downloads, ensuring the correct message structure is provided. Additionally, there are minor UI and style improvements.

The most important changes are:

Code Style and Consistency:

  • Converted all string literals from single quotes to double quotes across multiple files for consistency (src/components/DownloadDialog.tsx, src/pages/entryPoint/ExampleModal.tsx, and others). [1] [2]
  • Refactored several function calls and object initializations to be more concise and consistent with the new string style. [1] [2] [3]

Functionality Fixes:

  • Fixed the DownloadDialog in both LeftDrawer.tsx and QueryBuilder.tsx to pass the correct message object for the "all_queries" download type, ensuring the dialog receives the full query message instead of just the query_graph. [1] [2]

UI and Style Updates:

  • Updated some inline styles and class names to use double quotes and improved style consistency in ExampleModal.tsx and Download.tsx. [1] [2]
  • Added a CSS rule to adjust the font size of .MuiTypography-h5 for better visual hierarchy.

Logic Improvements:

  • Improved default file naming and dialog title in DownloadDialog.tsx to better reflect the download type ("Query" vs. "Answer"). [1] [2]
  • Simplified logic in various places, such as the construction of CSV data and the handling of example queries. [1] [2]

These changes collectively improve code readability, maintainability, and user experience.

Closes RobokopU24/Feedback#284
Closes RobokopU24/Feedback#285

@Amaru333 Amaru333 requested a review from Woozl March 19, 2026 16:49
@Woozl Woozl merged commit d5ab439 into main Mar 23, 2026
2 checks passed
@Woozl Woozl deleted the updates/minor-fixes branch March 23, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Result doesn't show edge Question builder annoying

2 participants