Add missing service timeout parameter to conditional launch #1028
Merged
Conversation
bjsowa
approved these changes
Apr 30, 2025
bjsowa
added a commit
that referenced
this pull request
Apr 30, 2025
bjsowa
added a commit
that referenced
this pull request
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
Add a missing parameter (default_call_servie_timeout) to the rosbridge_websocket node. The parameter is added when ssl:=True but not when ssl:=False.
Description
Motivation behind those changes: I was using the bridge to make calls to services that take 10-20 seconds to return (request for a robot to navigate slightly long distances). I noted that regardless of my increasing the service timeout in the launch file, rosbridge was still throwing exceptions. Then I realized the parameter was not actually being passed to the rosbridge_websocket node when ssl:=False.
This PR addresses this issue: #1027