fix(ROS2TFClient): Use correct action type for ROS2 tf2_web_republisher #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ROS2 version of tf2-web-republisher, the correct Action name should be tf2_web_republisher_interfaces/action/TFSubscription. Fixing this will allow PointCloud2 to be displayed correctly on the web page. This change has been tested on ROS2 Kilted, Ubuntu 24.04 and works for me.
Public API Changes
None
Description
The ROS2TFClient component currently uses a hardcoded action type (tf2_web_republisher_msgs/TFSubscription) This makes the client incompatible with standard ROS 2 tf2_web_republisher, which expect the action type to be tf2_web_republisher_interfaces/action/TFSubscription.
This commit corrects the hardcoded action type to the proper ROS 2 version. As a result, TF-dependent visualizations like PointCloud2 can now be displayed correctly on a web page when using a ROS 2 backend, resolving a critical compatibility issue.
This change has been tested and verified on ROS 2 Kilted with Ubuntu 24.04.
Resolves #948