Skip to content

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Sep 22, 2025

Proposed changes

Removes:

  • app/lib/constants/index.ts
  • app/lib/methods/index.ts
  • app/lib/hooks/index.ts
  • app/lib/services/index.ts

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1032

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Contributor

coderabbitai bot commented Sep 22, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

175 files out of 282 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore.remove-barrel-files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@diegolmello diegolmello marked this pull request as ready for review September 22, 2025 18:06
@diegolmello diegolmello force-pushed the chore.remove-barrel-files branch from 2583fc2 to 102c989 Compare September 22, 2025 18:16
@diegolmello diegolmello temporarily deployed to approve_e2e_testing September 22, 2025 18:16 — with GitHub Actions Inactive
@diegolmello diegolmello temporarily deployed to experimental_ios_build September 22, 2025 18:19 — with GitHub Actions Inactive
@diegolmello diegolmello temporarily deployed to experimental_android_build September 22, 2025 18:19 — with GitHub Actions Inactive
Copy link

iOS Build Available

Rocket.Chat Experimental 4.65.0.107358

@diegolmello diegolmello had a problem deploying to upload_experimental_android September 22, 2025 18:53 — with GitHub Actions Error
Copy link

Android Build Available

Rocket.Chat Experimental 4.65.0.107357

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNRHZutXkUB6WI1BKIkRQgudCdv-Y70q4Dheiecn6ANRvcgeSltnyp4mkFje5oRvFRf50efFgHVUPWWGKSe9

Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great job!

@diegolmello diegolmello merged commit d9a852c into develop Sep 25, 2025
6 of 9 checks passed
@diegolmello diegolmello deleted the chore.remove-barrel-files branch September 25, 2025 20:33
@diegolmello diegolmello requested a deployment to experimental_ios_build September 25, 2025 20:35 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to official_android_build September 25, 2025 20:35 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to experimental_android_build September 25, 2025 20:35 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants