Skip to content

Conversation

@Rohit3523
Copy link
Collaborator

@Rohit3523 Rohit3523 commented Nov 17, 2025

Proposed changes

  1. if i send any markdown message using tooltip and try to use the tooltip again, cursor will show next to 2nd symbol
  2. improve the codeblock markdown, the correct format is "```\ntext\n```" not "```text```"
Screenshot 2025-11-20 at 10 56 35 PM

Issue(s)

How to test or reproduce

Screenshots

  1. iOS markdown composer fixed
    Before: https://github.com/user-attachments/assets/d3c42401-81a3-4061-ad61-b5bd6f32ce5f
    After: https://github.com/user-attachments/assets/21302028-4aeb-4a3e-8b22-6fde7860b113

  2. Codeblock markdown fix

OS Before After
Android https://github.com/user-attachments/assets/aa71bc32-b1ac-491f-bfa1-cb77408a5170 https://github.com/user-attachments/assets/78f9151e-e3a8-4b8d-af38-005596d330f2
iOS https://github.com/user-attachments/assets/d9819da2-d46d-45dc-9fee-09e84908b8b8 https://github.com/user-attachments/assets/2a233dc8-2f9b-4d95-ba1b-7eba63a44027

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 17, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch markdown-improve

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Rohit3523 Rohit3523 had a problem deploying to official_android_build November 17, 2025 12:31 — with GitHub Actions Error
@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build November 17, 2025 12:31 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to experimental_android_build November 17, 2025 12:31 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to official_ios_build November 17, 2025 12:31 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to upload_official_ios November 17, 2025 13:10 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to upload_experimental_android November 17, 2025 13:17 — with GitHub Actions Error
@github-actions
Copy link

Android Build Available

Rocket.Chat Experimental 4.67.0.107715

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNRNkIEkT6j4eIJftZ7n4A7P15Sxwb5htIWHWgIMFDj_tdvLkc-4RP-FuZXqZbP7sGwdJtt4L4JOkPBkA7nQ

@github-actions
Copy link

iOS Build Available

Rocket.Chat Experimental 4.67.0.107716

@github-actions
Copy link

iOS Build Available

Rocket.Chat 4.67.0.107714

@Rohit3523
Copy link
Collaborator Author

Requesting an early review

@Rohit3523 Rohit3523 requested a deployment to official_android_build November 27, 2025 19:56 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build November 27, 2025 19:56 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 requested a deployment to experimental_android_build November 27, 2025 19:56 — with GitHub Actions Waiting
@github-actions
Copy link

iOS Build Available

Rocket.Chat Experimental 4.68.0.107764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants