Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove nexcloud meteor startup & tracker #34996

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jan 21, 2025

ARCH-1417

also removes some workarounds that existed when the server and client shared the same file

Copy link
Contributor

dionisio-bot bot commented Jan 21, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: a0f7140

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (460778e) to head (a0f7140).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34996      +/-   ##
===========================================
- Coverage    59.17%   59.17%   -0.01%     
===========================================
  Files         2822     2822              
  Lines        68069    68058      -11     
  Branches     15136    15134       -2     
===========================================
- Hits         40283    40274       -9     
+ Misses       24956    24954       -2     
  Partials      2830     2830              
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 21, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34996/

Built to branch gh-pages at 2025-01-29 17:34 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review January 23, 2025 12:33
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner January 23, 2025 12:33
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename lib.ts to useNextcloud.ts?

gabriellsh
gabriellsh previously approved these changes Jan 28, 2025
@MartinSchoeler MartinSchoeler added this to the 7.4.0 milestone Jan 29, 2025
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jan 29, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 29, 2025
@kodiakhq kodiakhq bot merged commit 4f1021a into develop Jan 29, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the remove-meteor-method/nexcloud branch January 29, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants