-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove nexcloud meteor startup & tracker #34996
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34996 +/- ##
===========================================
- Coverage 59.17% 59.17% -0.01%
===========================================
Files 2822 2822
Lines 68069 68058 -11
Branches 15136 15134 -2
===========================================
- Hits 40283 40274 -9
+ Misses 24956 24954 -2
Partials 2830 2830
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename lib.ts
to useNextcloud.ts
?
ARCH-1417
also removes some workarounds that existed when the server and client shared the same file