Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: refactoring the data folder #721

Merged
merged 19 commits into from
Nov 9, 2024
Merged

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Nov 2, 2024

Pull request type

  • ReadMe, Docs and GitHub updates

Checklist

  • [x ] Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

The data and tests folder are really messy, see issue #281

New behavior

  • Reorganized the data folder
  • Avoided file repetitions
  • Updated paths in the tests and examples notebooks
  • Both slow and normal tests are passing locally.
  • Still needs to build the documentation on readthedocs and verify it is working.

Breaking change

  • No, but some examples may fail due to "file not found error", so we need to keep an eye on that.

Additional information

At the beggining it seemed an easy task, but believe me it wasn't.

Sorry, something went wrong.

@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner November 2, 2024 14:51
@Gui-FernandesBR Gui-FernandesBR linked an issue Nov 2, 2024 that may be closed by this pull request
5 tasks
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (b838d53) to head (cfe00ec).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #721   +/-   ##
========================================
  Coverage    76.03%   76.03%           
========================================
  Files           94       94           
  Lines        10981    10981           
========================================
  Hits          8349     8349           
  Misses        2632     2632           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliobarbosa
Copy link

@Gui-FernandesBR Maybe the discussion I posted on issue #281 is relevant for this PR.

@Gui-FernandesBR
Copy link
Member Author

Read the docs not passing, although I don't now why (yet).

image

@Gui-FernandesBR Gui-FernandesBR added the Git housekeeping Clean and organize our github label Nov 9, 2024
@Gui-FernandesBR Gui-FernandesBR merged commit 59072c5 into develop Nov 9, 2024
10 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the git/update-data-folder branch November 9, 2024 01:26
Gui-FernandesBR added a commit that referenced this pull request Nov 9, 2024
MNT: refactoring the data folder (#721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Git housekeeping Clean and organize our github
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

MNT: Cleaning the data folder
3 participants