- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: refactoring the data folder #721
Merged
Merged
+4,402
−56,954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #721 +/- ##
========================================
Coverage 76.03% 76.03%
========================================
Files 94 94
Lines 10981 10981
========================================
Hits 8349 8349
Misses 2632 2632 ☔ View full report in Codecov by Sentry. |
6777507
to
659447a
Compare
@Gui-FernandesBR Maybe the discussion I posted on issue #281 is relevant for this PR. |
…Team/RocketPy into git/update-data-folder
dc07674
to
977dcbd
Compare
…Team/RocketPy into git/update-data-folder
phmbressan
approved these changes
Nov 8, 2024
Gui-FernandesBR
added a commit
that referenced
this pull request
Nov 9, 2024
MNT: refactoring the data folder (#721)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
The data and tests folder are really messy, see issue #281
New behavior
Breaking change
Additional information
At the beggining it seemed an easy task, but believe me it wasn't.