Fix deprecated api #102
Merged
Fix deprecated api #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walkingice
force-pushed
the
fix_deprecated_api
branch
from
ab55228 to
ab7e33e
Compare
walkingice
force-pushed
the
fix_deprecated_api
branch
2 times, most recently
from
0cab6db to
86fe083
Compare
we don't actually remove the deprecated API. Just add a util class so we can refactor it later
walkingice
force-pushed
the
fix_deprecated_api
branch
from
86fe083 to
75f8f52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove some deprecated API