Issue 92 make menus be expandable #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extract the function of setting corner, then we can decide to apply rounded corner or not
do not move the whole root view, instead, move only the specified view
* use ConstraintLayout to replace nested LinearLayout
* Apply CoordinateLayout to make it to be swipe-to-dismiss
known issue:
If the list was too long, and user's phone screen was short, maybe
we cannot see the whole list. I tried adding NestedScrollView but
sometimes the Y-position of root view is not correct while first
time opening the BottomSheet. Mabye it is because HomeMenuDialog is
a BototmSheetDialog. We should try to use Fragment instead.
There are 2 CoordinateLayout since HomeMenuDialog is extending
BottomSheetDialog. This is not right.
Reproduce step:
set layout_height=500dp to menu_night_mode
avoid using BottomSheetDialog, create a DialogFragment for showing Home Menu
avoid using BottomSheetDialog, create a DialogFragment for showing Home Menu
walkingice
force-pushed
the
issue_92_make_menus_be_expandable
branch
from
11200a7 to
a539106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Home Menu and Browser Menu, remove
BottomSheetDialogand useDialogFragmentinstead. And make them looks like Bottom Sheet Dialogto fix #92