Issue 118 completely display webview content #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AppBar/ToolBar/TopBar, is hide-able and will expand again on user scrolling. This commit tries to remove the behavior, and make it always stick at top. Instead of using Material library, we are going to implement it by ourself in subsequent commits.
We are not using HideBottomViewOnScrollBehavior anymore.
We are not using Behavior to slide up/down the BottomBar. Now let BottomBar do the task itself.
FrameLayout is enought. It does not really need to be a CoordinatorLayout
In previous commits, the meterial appbar layout was removed. The whole layout could be rewrote for better performance. Also rename some id to make IDE happy.
UrlBar are layouting itself along with WebView(slot) and BottomBar. To make them stay in same parent makes more sense. By doing this, the xml file becomes clear, and we only need to care about height of `insetCover`. That is for showing background under System StatusBar.
This is for the WebViewSlot that contains a NestedWebView. To make the NestedWebView cooperate with CooridnatorLayout, we needs a Nested-ViewGroup to bridge them.
This is a dedicate Behavior for Rocket's scrolling. When user scroll the WebView, Top/BottomBar will be changed along with WebView. The Behavior receives events from CoordinatorLayout, and pass events to the controller to decide how to layout AppBar, WebView and BottomBar.
do not control the BottomBar directly, move all tasks to Controller. * We are going to remove all Shopping* stuffs later.
walkingice
force-pushed
the
issue-118-completely_display_webview_content
branch
from
e8d0e7c to
c3940be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhaul
fragment_browser.xml, and implementing a custom Behavior to slide up/down UrlBar. to fix #118