Skip to content

Commit

Permalink
[LIVY-695] Upgrade JQuery to 3.4.1 and Bootstrap to 3.4.1
Browse files Browse the repository at this point in the history
## What changes were proposed in this pull request?

This PR:
- updates JQuery to 3.4.1
- updates Bootstrap to 3.4.1
- switches to minified version of Bootstrap
- removes unused old bootstrap files

The changes are needed to fix CVEs.

## How was this patch tested?

Manual tests:
- Livy Server UI looks ok
- Documentation had a minor issue of logo position after plain upgrade, but fix is included in this commit

Author: Peter Toth <[email protected]>
Author: Peter Toth <[email protected]>

Closes apache#245 from peter-toth/LIVY-695-upgrade-bootstrap-to-3.4.1.
  • Loading branch information
peter-toth authored and ajbozarth committed Oct 14, 2019
1 parent 2e7d691 commit 85837e3
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .rat-excludes
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ logs/*
**/dataTables.bootstrap.min.css
**/dataTables.bootstrap.min.js
**/jquery.dataTables.min.js
**/jquery-3.2.1.min.js
**/jquery-3.4.1.min.js
**/fonts/**
**/livy_python_api.egg-info/*
**/*.txt
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

This file was deleted.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class UIServlet(val basePath: String, livyConf: LivyConf) extends ScalatraServle
href={basePath + "/static/css/dataTables.bootstrap.min.css"}
type="text/css"/>
<link rel="stylesheet" href={basePath + "/static/css/livy-ui.css"} type="text/css"/>
<script src={basePath + "/static/js/jquery-3.2.1.min.js"}></script>
<script src={basePath + "/static/js/jquery-3.4.1.min.js"}></script>
<script src={basePath + "/static/js/bootstrap.min.js"}></script>
<script src={basePath + "/static/js/jquery.dataTables.min.js"}></script>
<script src={basePath + "/static/js/dataTables.bootstrap.min.js"}></script>
Expand Down

0 comments on commit 85837e3

Please sign in to comment.